fix: ignore EADDRNOTAVAIL error when listen localhost #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if localhost refer to the ip that is not unkonwn on the machine, you will see the error EADDRNOTAVAIL https://stackoverflow.com/questions/10809740/listen-eaddrnotavail-error-in-node-js
|
好像不太好模拟 |
|
为啥不直接去掉localhost的处理呢，或者换成127.0.0.1。 如果直接抛出 EADDRNOTAVAIL 这个错误码，使用者可能还得去查一遍才知道怎么才能解决 |
|
考虑到 localhost 可能配置成其他的，需求和 bug 分开处理。 还有测试绑定 localhost，需要重构下。 |
fengmk2
approved these changes
May 16, 2018
|
1.2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if localhost refer to the ip that is not unkonwn on the machine, you will see the error EADDRNOTAVAIL
https://stackoverflow.com/questions/10809740/listen-eaddrnotavail-error-in-node-js