feat: first implement #2

popomore · 2017-02-08T11:37:40Z

support require index or files

const mkdirp = require('mz-modules').mkdirp;
const mkdirp = require('mz-modules/mkdirp');

modules

mz-modules/mkdirp wrapped mkdirp
mz-modules/rimraf wrapped rimraf
mz-modules/glob wrapped glob
mz-modules/sleep wrapped ko-sleep
mz-modules/nextTick wrapped process.nextTick
mz-modules/setImmediate wrapped setImmediate

Closes #1

support require index or files ```js const mkdirp = require('mz-modules').mkdirp; const mkdirp = require('mz-modules/mkdirp'); ``` modules - mkdirp - rimraf - sleep - nexttick - glob

codecov · 2017-02-08T11:40:21Z

Codecov Report

❗ No coverage uploaded for pull request base (master@7626020). Click here to learn what that means.

@@           Coverage Diff           @@
##             master     #2   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      8           
  Lines             ?     24           
  Branches          ?      0           
=======================================
  Hits              ?     24           
  Misses            ?      0           
  Partials          ?      0

Impacted Files	Coverage Δ
nextTick.js	`100% <100%> (ø)`
mkdirp.js	`100% <100%> (ø)`
glob.js	`100% <100%> (ø)`
lib/wrap.js	`100% <100%> (ø)`
rimraf.js	`100% <100%> (ø)`
setImmediate.js	`100% <100%> (ø)`
index.js	`100% <100%> (ø)`
sleep.js	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7626020...1b544ef. Read the comment docs.

fengmk2 · 2017-02-08T14:37:03Z

index.js

+'use strict';
+
+module.exports = {
+  mkdirp: require('./mkdirp'),


写成 getter 吧，要不然就变成只使用 sleep，然后所有模块都 require 进来了。

这个不改了吧，提供两种方式

fengmk2 · 2017-02-08T14:41:31Z

nexttick.js

@@ -0,0 +1,7 @@
+'use strict';


是不是也要一个 setImmediate ?

popomore · 2017-02-08T14:41:39Z

这不是推荐方式，看看 readme fengmk2 <notifications@github.com>于2017年2月8日周三22:37写道：

…

***@***.**** commented on this pull request. ------------------------------ In index.js <#2 (review)> : > @@ -0,0 +1,9 @@ +'use strict'; + +module.exports = { + mkdirp: require('./mkdirp'), 写成 getter 吧，要不然就变成只使用 sleep，然后所有模块都 require 进来了。 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWA1WX8Xy6YXP0UGMbO-j7EK7C1vWGCks5radMQgaJpZM4L6thW> .

popomore · 2017-02-08T14:42:33Z

加一下，我还在纠结要不要驼峰 fengmk2 <notifications@github.com>于2017年2月8日周三22:41写道：

…

***@***.**** commented on this pull request. ------------------------------ In nexttick.js <#2 (review)> : > @@ -0,0 +1,7 @@ +'use strict'; 是不是也要一个 setImmediate ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWA1bJS-Yhpy79pQComvCg8nhr0qVIDks5radQcgaJpZM4L6thW> .

fengmk2 · 2017-02-08T14:42:46Z

nexttick.js

+
+module.exports = () => {
+  return new Promise(resolve => {
+    process.nextTick(resolve);


呃，我记得 Promise 默认就是自动加 nextTick 的，所以这里直接 return new Promise(resolve => { resolve(); }); 就好

nodejs/node#2736 (comment) Promise 默认在 nextTick 队列之后触发

nextTick 感觉可以不提供了，需要的人直接写 yield Promise.resolve() 即可

可以这样写 module.exports = () => Promise.resolve();

实际测试 Promise.then() 好像是用的 setImmediate 而不是 process.nextTick

promise 没法做到 nextTick 的，感觉这个会有点误导？

那还是用真的 nextTick 吧，不要 hack 了

popomore · 2017-02-09T03:19:34Z

nextTick.js 我改成大写吧，保持一致

popomore · 2017-02-09T04:07:03Z

写了个公用方法，再看看

popomore · 2017-02-09T04:12:26Z

改完了去各个仓库安利

popomore · 2017-02-09T05:23:01Z

过了

fengmk2 · 2017-02-09T07:40:58Z

setImmediate.js

@@ -0,0 +1,3 @@
+'use strict';
+
+module.exports = () => new Promise(resolve => setImmediate(resolve));


这个好像无解，只能这样。其实这里是 nextTick 然后再一次 setImmediate

promise 用的是 setImmediate，不是 nextTick，所以是 nextTick 无解。。

process.nextTick(() => console.log(1)); Promise.resolve().then(() => console.log(2)); process.nextTick(() => console.log(3)); // => // 1 // 3 // 2

setImmediate(() => console.log(1)); Promise.resolve().then(() => console.log(2)); setImmediate(() => console.log(3)); // => // 2 // 1 // 3

额，都不是，尴尬了。

Promise.resolve 在 nextTick 之后，setImmediate 之前。所以相对于 nextTick，setImmediate 了

是的，这里要不换一个没这么歧义的名字？

把这个用例加上

popomore · 2017-02-09T08:24:40Z

用例加了

popomore · 2017-02-09T10:12:17Z

npminstall 跑太慢，测试过了

popomore added 2 commits February 8, 2017 19:32

feat: first implement

d1e70c0

support require index or files ```js const mkdirp = require('mz-modules').mkdirp; const mkdirp = require('mz-modules/mkdirp'); ``` modules - mkdirp - rimraf - sleep - nexttick - glob

doc

9f47c10

f

169bb58

popomore requested review from fengmk2 and dead-horse February 8, 2017 12:45

fengmk2 reviewed Feb 8, 2017

View reviewed changes

nexttick.js Outdated

@@ -0,0 +1,7 @@

'use strict';

Copy link

Member

fengmk2 Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是也要一个 setImmediate ?

fengmk2 reviewed Feb 8, 2017

View reviewed changes

popomore added 2 commits February 9, 2017 11:30

f

742a1ad

f

cb24a64

popomore added 3 commits February 9, 2017 12:08

f

a1b9e93

f

e642781

f

508793f

popomore added 5 commits February 9, 2017 12:19

f

34ed737

f

2507380

f

618c532

f

117315c

f

ac34d8d

fengmk2 reviewed Feb 9, 2017

View reviewed changes

fengmk2 approved these changes Feb 9, 2017

View reviewed changes

popomore added 2 commits February 9, 2017 16:17

f

48bf937

f

488bcc9

f

1b544ef

popomore merged commit af94cb8 into master Feb 9, 2017

popomore deleted the first branch February 9, 2017 10:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: first implement #2

feat: first implement #2

popomore commented Feb 8, 2017 •

edited

codecov bot commented Feb 8, 2017 •

edited

fengmk2 Feb 8, 2017

popomore Feb 9, 2017

fengmk2 Feb 8, 2017

popomore commented Feb 8, 2017 via email

popomore commented Feb 8, 2017 via email

fengmk2 Feb 8, 2017

fengmk2 Feb 8, 2017

fengmk2 Feb 8, 2017

dead-horse Feb 8, 2017

dead-horse Feb 9, 2017

popomore Feb 9, 2017

popomore commented Feb 9, 2017

popomore commented Feb 9, 2017

popomore commented Feb 9, 2017

popomore commented Feb 9, 2017

fengmk2 Feb 9, 2017

dead-horse Feb 9, 2017

dead-horse Feb 9, 2017

dead-horse Feb 9, 2017

fengmk2 Feb 9, 2017

dead-horse Feb 9, 2017

popomore Feb 9, 2017

popomore commented Feb 9, 2017

popomore commented Feb 9, 2017

		@@ -0,0 +1,3 @@
		'use strict';

		module.exports = () => new Promise(resolve => setImmediate(resolve));

feat: first implement #2

feat: first implement #2

Conversation

popomore commented Feb 8, 2017 • edited

codecov bot commented Feb 8, 2017 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

popomore commented Feb 8, 2017 via email

popomore commented Feb 8, 2017 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

popomore commented Feb 9, 2017

popomore commented Feb 9, 2017

popomore commented Feb 9, 2017

popomore commented Feb 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

popomore commented Feb 9, 2017

popomore commented Feb 9, 2017

popomore commented Feb 8, 2017 •

edited

codecov bot commented Feb 8, 2017 •

edited