-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support client.await #7
Conversation
@dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gxcsoccer and @fengmk2 to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 73 75 +2
=====================================
+ Hits 73 75 +2
Continue to review full report at Codecov.
|
@@ -77,50 +77,58 @@ co(function* () { | |||
|
|||
- `.ready(flagOrFunction)` flagOrFunction is optional, and the argument type can be Boolean, Error or Function. | |||
|
|||
```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为啥把缩进去掉了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我还原
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
缩进没去掉,这个缩进多了一级。
@leoner 合并 PR 的时候可以做合并的 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
package.json
Outdated
@@ -28,6 +28,7 @@ | |||
}, | |||
"license": "MIT", | |||
"dependencies": { | |||
"await-event": "^1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我手动合并。
3.1.0 |
No description provided.