Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep the same req object across request and response event #247

Merged
merged 2 commits into from Feb 6, 2017

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Feb 4, 2017

@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dotnil, @dead-horse and @xingrz to be potential reviewers.

@codecov-io
Copy link

codecov-io commented Feb 4, 2017

Codecov Report

Merging #247 into master will increase coverage by -0.38%.

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   98.23%   97.85%   -0.38%     
==========================================
  Files           4        4              
  Lines         509      513       +4     
  Branches      127      127              
==========================================
+ Hits          500      502       +2     
- Misses          9       11       +2
Impacted Files Coverage Δ
lib/urllib.js 97.91% <100%> (-0.45%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e0ca7...093c0c5. Read the comment docs.

@fengmk2 fengmk2 merged commit 805201e into master Feb 6, 2017
@fengmk2 fengmk2 deleted the fix-keep-req-obj branch February 6, 2017 07:38
@fengmk2
Copy link
Member Author

fengmk2 commented Feb 6, 2017

2.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants