Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose status message from original Response #306

Merged
merged 3 commits into from Jan 7, 2019
Merged

Expose status message from original Response #306

merged 3 commits into from Jan 7, 2019

Conversation

paambaati
Copy link
Contributor

This PR exposes statusMessage from the original Response object.

This helps in cases where servers can use custom status messages.

@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #306 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   92.55%   92.57%   +0.02%     
==========================================
  Files           6        6              
  Lines         725      727       +2     
  Branches      203      203              
==========================================
+ Hits          671      673       +2     
  Misses         54       54
Impacted Files Coverage Δ
lib/urllib.js 95.95% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251b065...97ca1d0. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #306 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   92.55%   92.57%   +0.02%     
==========================================
  Files           6        6              
  Lines         725      727       +2     
  Branches      203      203              
==========================================
+ Hits          671      673       +2     
  Misses         54       54
Impacted Files Coverage Δ
lib/urllib.js 95.95% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251b065...4c60d04. Read the comment docs.

@paambaati
Copy link
Contributor Author

paambaati commented Dec 24, 2018

@fengmk2 All CIs green, except for macOS/Node 8 on Azure. This seems like a flake.

@fengmk2 fengmk2 added the feature label Jan 7, 2019
@fengmk2 fengmk2 merged commit 79e8453 into node-modules:master Jan 7, 2019
@fengmk2
Copy link
Member

fengmk2 commented Jan 7, 2019

2.32.0 Released.

@paambaati Thanks and sorry for the delay reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants