fix: ignore request error if request is done #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killagu
force-pushed
the
fix/ignore_error
branch
from
fc61610
to
94d7f5e
Compare
qile222
reviewed
Jun 28, 2022
fengmk2
reviewed
Jun 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
==========================================
+ Coverage 93.04% 93.24% +0.19%
==========================================
Files 6 6
Lines 820 829 +9
Branches 223 225 +2
==========================================
+ Hits 763 773 +10
+ Misses 57 56 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fengmk2
reviewed
Jul 5, 2022
| // err = new Error('Remote socket was terminated before `response.end()` was called'); | ||
| // err.name = 'RemoteSocketClosedError'; | ||
| debug('Request#%d %s: Remote socket was terminated before `response.end()` was called', reqId, url); | ||
| var err = responseError || new Error('Remote socket was terminated before `response.end()` was called'); |
There was a problem hiding this comment.
responseError 的变量定义应该放在 decodeContent 前面。
fengmk2
approved these changes
Jul 5, 2022
|
2.38.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.