Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid deps vm2 #457

Merged
merged 3 commits into from
Jul 28, 2023
Merged

feat: avoid deps vm2 #457

merged 3 commits into from
Jul 28, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jul 23, 2023

move proxy-agent to peerDependencies and make it optional

closes eggjs/egg#5239

move proxy-agent to peerDependencies and make it optional

closes eggjs/egg#5239
@fengmk2 fengmk2 added the enhancement New feature or request label Jul 23, 2023
@fengmk2 fengmk2 requested a review from killagu July 23, 2023 15:17
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: autod@3.1.2, intelli-espower-loader@1.1.0, power-assert@1.6.1

@gemwuu
Copy link
Member

gemwuu commented Jul 24, 2023

需要把 proxy-agent 加到 devDependencies 里面,不然单测会挂。

@fengmk2 fengmk2 requested a review from gemwuu July 26, 2023 16:09
@fengmk2
Copy link
Member Author

fengmk2 commented Jul 26, 2023

需要把 proxy-agent 加到 devDependencies 里面,不然单测会挂。

fixed

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #457 (603b90d) into 2.x (126a938) will decrease coverage by 1.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x     #457      +/-   ##
==========================================
- Coverage   93.24%   91.79%   -1.45%     
==========================================
  Files           6        6              
  Lines         829      829              
  Branches      225      225              
==========================================
- Hits          773      761      -12     
- Misses         56       68      +12     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fengmk2 fengmk2 merged commit 9dbcc78 into 2.x Jul 28, 2023
17 of 18 checks passed
@fengmk2 fengmk2 deleted the mv-proxy-agent-to-peerDependencies branch July 28, 2023 05:29
@fengmk2
Copy link
Member Author

fengmk2 commented Jul 28, 2023

  • urllib@2.41.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants