Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add setMaxListeners to stream.prototype #2

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Conversation

popomore
Copy link
Member

@popomore popomore commented Dec 1, 2016

readable-stream is listening event on the prototype of stream

@codecov-io
Copy link

codecov-io commented Dec 1, 2016

Current coverage is 96.15% (diff: 100%)

Merging #2 into master will decrease coverage by 1.84%

@@             master         #2   diff @@
==========================================
  Files             1          1          
  Lines            50         52     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             49         50     +1   
- Misses            1          2     +1   
  Partials          0          0          

Powered by Codecov. Last update fb519f7...9114a10


// https://github.com/nodejs/readable-stream/blob/master/lib/_stream_readable.js#L667
// readable-stream is listening event on the prototype of stream
stream.prototype.setMaxListeners(100);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥要修改全局的?

@popomore
Copy link
Member Author

popomore commented Dec 1, 2016 via email

@fengmk2
Copy link
Member

fengmk2 commented Dec 1, 2016

谁用了?没看懂上下文。

@popomore
Copy link
Member Author

popomore commented Dec 1, 2016 via email

@fengmk2
Copy link
Member

fengmk2 commented Dec 1, 2016

那也应该只是设置一个 Readable 实例的才对,而不是全局的。

@popomore
Copy link
Member Author

popomore commented Dec 2, 2016 via email

@popomore
Copy link
Member Author

popomore commented Dec 2, 2016

我尝试下不用他的库

@popomore
Copy link
Member Author

popomore commented Dec 2, 2016

改了,readable-stream 是继承 stream 的,设在这个上面也是可以的,不过总感觉实现奇怪。

@popomore
Copy link
Member Author

@fengmk2

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@fengmk2 fengmk2 merged commit 2954141 into master Dec 12, 2016
@fengmk2 fengmk2 deleted the setMaxListeners branch December 12, 2016 16:09
@fengmk2
Copy link
Member

fengmk2 commented Dec 12, 2016

@popomore 你来发布吧。

@popomore
Copy link
Member Author

  • zlogger@1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants