feat(match_body): urlencoded body matches not only string values

[arusakov]

It's first step to resolving issue #1106.

I think, that this behaviour is good, but can be unexpected for long-time nock users. Maybe we need an option to enable this behaviour?
Also RegExp values are turning into strings. It's not good. (Updated)
I can continue what I started if the whole approach is acceptable.
Review please @gr2m.

[gr2m]

hey sorry I’m out vacationing (mostly) until April 22nd. At first glance the changes look good to me, as long as all current tests pass I’m okay with it. If we break things, we’ll fix them and improve the tests :)

[arusakov]

Little update with one more test. RegExp values are processed correctly.

[gr2m]

Thanks @arusakov, looking great!

[nockbot]

🎉 This PR is included in version 9.2.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[leggsimon]

Just an FYI, it seems that this broke our tests, since we needed to JSON.stringify some bodies instead now. Not sure this should have been a patch release

[arusakov]

@leggsimon
Thank you for feedback. Can you provide some test cases?

[leggsimon]

@arusakov I'll try and get around to it today yes

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!