Skip to content
This repository has been archived by the owner on Jan 5, 2019. It is now read-only.

Fix nock usage from change in api #36

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Fix nock usage from change in api #36

merged 1 commit into from
Jul 31, 2018

Conversation

imbstack
Copy link
Contributor

Took me a bit, but I found that you ended up with a newer version of nock than the rest of us. They changed their api without a major version bump in nock/nock#1110 and you got caught on it. This should fix it!

@imbstack imbstack requested a review from jhford July 31, 2018 22:24
@imbstack imbstack requested review from eliperelman and removed request for jhford July 31, 2018 22:33
Copy link
Contributor

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ 💯

@imbstack imbstack merged commit 51a93e3 into master Jul 31, 2018
@imbstack imbstack deleted the fix-nock-sadness branch July 31, 2018 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants