Fixed issue with record -> replay body encoding

[simlu]

This matches the replay decode check in https://github.com/node-nock/nock/blob/master/lib/request_overrider.js#L325

Ideally we would also add a corresponding check for isBinaryRequestBodyBuffer (https://github.com/node-nock/nock/blob/master/lib/request_overrider.js#L347):

if((common.isContentEncoded(headers) || isBinaryRequestBodyBuffer) && common.isBinaryBuffer(mergedBuffer)) { ...

However I wanted to keep this pr small and get some feedback.

[simlu]

So I was thinking about this more. The appropriate way of doing this is to store the binary or hex information in the recoding and not try and guess it. Agreed?

[ierceg]

@simlu Thank you for the PR. We would however need tests to show what was wrong with the previous behavior and how this change fixes it.

Also, I'm not following re storing the binary/hex information in the recording - is there any metadata that we aren't capturing?

[simlu]

@ierceg All meta information is captured. However the logic to determine if the data should be stored/loaded as binary is different. Centralizing this logic would also solve this issue. However it might be easier to just store that information as binary=true/false.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!