-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not automatically consume responses, respect original consumer. #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Do not merge yet, will improve the test to actually run on node 0.10. |
satazor
force-pushed
the
request-promise
branch
from
March 20, 2016 02:41
8795717
to
4ed346e
Compare
satazor
force-pushed
the
request-promise
branch
from
March 20, 2016 02:45
4ed346e
to
1e8f0d3
Compare
Good to be merged. |
satazor
force-pushed
the
request-promise
branch
from
March 20, 2016 02:49
1e8f0d3
to
477f159
Compare
@satazor thanks! Landed on v7.5.0 |
<3 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486
After investigation, the issue is that the
recorder
assumes that all listeners are attached after http.request'scallback
is called which might not be the case. That's exactly what was happening with me because since got is using promises, thedata
event was only attached in the next event loop.Test case & fix added, I haven't committed the browserify bundle. I've tried to follow the coding style, let me know if something needs to be changed.