Solves #920

[edorivai]

Straightforward fix of #920

[coveralls]

Coverage increased (+0.02%) to 92.702% when pulling a109522 on edorivai:master into 17d7c25 on node-nock:master.

[gr2m]

This change introduced a bug that surfaced at hoodiehq/hoodie-store-server-api#21, I’m investigating

[gr2m]

Actually the specs are wrong and your fix showed that for the first time 👏

[paulmelnikow]

What what?! 👏 Thanks @edorivai!

[CodeMan99]

Why does this change not count as a breaking change? This broke my tests and I had to dig to this pull request to find out why.

[paulmelnikow]

I have experience with some linters (e.g. jscs) which took an extremely strict interpretation of semver which said "a new error is a breaking change". However, for most libraries, fixing behavior that was previously outright incorrect is not usually a breaking change.

Since this change seems to have a high ecosystem impact, perhaps we should consider reverting it and re-shipping it with a major version change.

Alternatively we could make sure the intended behavior is clear in the changelog. I agree that developers shouldn't have to come to the PR.

[gr2m]

@CodeMan99 welcome to open source, it never is perfect, but we are all in this together :) we are all volunteering our time here, please keep that in mind 🤗

[CodeMan99]

@gr2m Was just an honest question, wasn't trying to be firm or abrasive. Sorry.

[gr2m]

No worries :) I understand your frustration, it caused the same for several of my projects and caused some work. We’ll soon automate releases with better changelogs, that should help a little.

[focusaurus]

A few tips if you unexpectedly hit this and don't know what to do.

1. See the full body so you can find the extra properties that are being sent but are missing from your expectation body.

nock(host).post("/", (body) => {
  console.log("Actual body: ", JSON.stringify(body, null, 2)); // fixme
  return true;
})

2. If you want loose matching, try integrating tmatch.

const tmatch = require("tmatch");

nock(host).post("/", (body) => tmatch(body, {key1: "foo", key2: /^z/}))

If you use the pattern above a lot, you may want to factor out a helper function.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!