docs(README.md) - fix info about mocking #958
Conversation
fix info about mocking requests more then 1
|
You added one line to the readme file and coverage level decreased. Probably there is a way to ignore README.md when collection coverage :) |
|
I don't know how to do it. For example: https://github.com/expressjs/express/blob/master/package.json#L93 lodash collects coverage with istanbul and then send that results to coveralls. Actually, there is source_files option in coveralls docs: https://coveralls.zendesk.com/hc/en-us/articles/201350799-API-Reference |
| @@ -135,6 +135,7 @@ Then the test can call the module, and the module will do the HTTP requests. | |||
| When you setup an interceptor for a URL and that interceptor is used, it is removed from the interceptor list. | |||
| This means that you can intercept 2 or more calls to the same URL and return different things on each of them. | |||
| It also means that you must setup one interceptor for each request you are going to have, otherwise nock will throw an error because that URL was not present in the interceptor list. | |||
| But if you whant use .persist() and then nock will always intercept the requests, read more in * [.persist()](#persist) | |||
There was a problem hiding this comment.
Could you rephrase the sentence to
If you don’t want interceptors to be removed as they are used, you can use the .persist() method.
Or add me as collaborator to your fork and I can fix it up for you :)
|
close and create #971 |
|
fixed via #971 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you! |
fix info about mocking requests more then 1