fix(handlers): skip varcheck for state when allowEmptyState #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
33 tasks
|
Hi, this pr code seems to me much better than the original pr proposal. Regards. |
jorenvandeweyer
approved these changes
Dec 5, 2021
|
@HappyZombies @jwerre can you please second-check and merge if everything is ok? |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements https://github.com/oauthjs/node-oauth2-server/pull/473/files
Linked issue(s)
#89
Involved parts of the project
Authorize handler
Added tests?
Added integration tests
OAuth2 standard
https://datatracker.ietf.org/doc/html/rfc6749.html#section-4.1.1
Reproduction
Clone, checkout branch, run tests