fix: passing description in UAVariableType/UAObjectType

node-opcua · Feb 6, 2022 · 68fc9e4 · 68fc9e4
1 parent 64b82e9
commit 68fc9e4
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 8 deletions.
diff --git a/packages/node-opcua-address-space/src/namespace_impl.ts b/packages/node-opcua-address-space/src/namespace_impl.ts
@@ -1838,6 +1838,7 @@ export class NamespaceImpl implements NamespacePrivate {
         const objectType = this.internalCreateNode({
             browseName: options.browseName,
             displayName: options.displayName,
+            description: options.description,
             eventNotifier: +options.eventNotifier,
             isAbstract: !!options.isAbstract,
             nodeClass,

diff --git a/packages/node-opcua-address-space/test/test_object_type.ts b/packages/node-opcua-address-space/test/test_object_type.ts
@@ -117,24 +117,40 @@ describe("testing UAObjectType", () => {
             isAbstract: false,
             subtypeOf: "BaseObjectType"
         });
-
-        objType.displayName.toString().should.eql("locale=null text=Some DisplayName");
 
+        objType.displayName.toString().should.eql("locale=null text=Some DisplayName");
 
-        const instance1 =objType.instantiate({
-            browseName: "Instance1",
+        const instance1 = objType.instantiate({
+            browseName: "Instance1"
         });
         instance1.displayName.toString().should.eql("locale=null text=Instance1");
 
-        const instance2 =objType.instantiate({
+        const instance2 = objType.instantiate({
             browseName: "Instance2",
             displayName: "Instance2 DisplayName"
         });
         instance2.displayName.toString().should.eql("locale=null text=Instance2 DisplayName");
 
-
         // tslint:disable:no-console
         debugLog(objType.toString());
-
-    }); 
+    });
+
+    it("UAObjectType: create should handle description - type 1", () => {
+        const namespace = addressSpace.getOwnNamespace();
+        const objectType = namespace.addObjectType({
+            browseName: "MyObjectType4",
+            description: "Some Description"
+        });
+
+        objectType.description.toString().should.eql("locale=null text=Some Description");
+    });
+    it("UAObjectType: create should handle description - type 2", () => {
+        const namespace = addressSpace.getOwnNamespace();
+        const objectType = namespace.addObjectType({
+            browseName: "MyObjectType5",
+            description: { text: "Some Description", locale: "en-US" }
+        });
+
+        objectType.description.toString().should.eql("locale=en-US text=Some Description");
+    });
 });
diff --git a/packages/node-opcua-address-space/test/test_variable_type.ts b/packages/node-opcua-address-space/test/test_variable_type.ts
@@ -245,5 +245,29 @@ describe("testing UAVariableType", () => {
         debugLog(varType.toString());
 ;
     }); 
+    it("UAVariableType: create should handle description - type 1", ()=>{
+        const namespace = addressSpace.getOwnNamespace();
+        const varType = namespace.addVariableType({
+            browseName: "MyVariableType4",
+            description: "Some Description",
+            isAbstract: false,
+            subtypeOf: "BaseVariableType"
+        });
+
+        varType.description.toString().should.eql("locale=null text=Some Description");
+
+    });
+    it("UAVariableType: create should handle description - type 2", ()=>{
+        const namespace = addressSpace.getOwnNamespace();
+        const varType = namespace.addVariableType({
+            browseName: "MyVariableType5",
+            description: { text: "Some Description", locale: "en-US" },
+            isAbstract: false,
+            subtypeOf: "BaseVariableType"
+        });
+
+        varType.description.toString().should.eql("locale=en-US text=Some Description");
+
+    }); 
 
 });