Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent implicit 'any[]' typing #766

Closed
wants to merge 1 commit into from
Closed

Prevent implicit 'any[]' typing #766

wants to merge 1 commit into from

Conversation

razzeee
Copy link
Contributor

@razzeee razzeee commented Apr 22, 2020

I'm not 100% sure why our project picks up this problem but your linter settings do not. But I feel like this is the best way to report this.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.811% when pulling b362b37 on Razzeee:patch-1 into c5378e6 on node-opcua:master.

@razzeee
Copy link
Contributor Author

razzeee commented Apr 23, 2020

This might have something to do with the inclusion of the *.ts files in the package that node-opcua ships? As --skipLibCheck might have been an option, but it only skips *.d.ts files.

@erossignon erossignon mentioned this pull request May 19, 2020
Closed
@erossignon
Copy link
Member

OK, this is now fixed in node-opcua. Thank you for spotted this out

@erossignon erossignon closed this May 19, 2020
@razzeee
Copy link
Contributor Author

razzeee commented May 20, 2020

First version including this fix is v2.6.0-alpha.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@razzeee @coveralls @erossignon