Support step-by-step stage sync #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setunapo
reviewed
May 31, 2023
| @@ -271,6 +271,8 @@ type HeaderDownload struct { | |||
| posDownloaderTip common.Hash // See https://hackmd.io/GDc0maGsQeKfP8o2C7L52w | |||
| badPoSHeaders map[common.Hash]common.Hash // Invalid Tip -> Last Valid Ancestor | |||
| stageSyncUpperBound uint64 // Upper bound for stage sync, stop sync upon reached this height | |||
| stageSyncStep uint64 // Step size of stage sync, e.g: if it's 1, then will sync block by block | |||
| stageSyncStepLeft uint64 // Left Step size of stage sync | |||
There was a problem hiding this comment.
why not just update stageSyncUpperBound for each step? then no need this flag: stageSyncStepLeft
There was a problem hiding this comment.
I think stageSyncUpperBound is the height which would be suppressed and will be stuck without processing. Step is another feature that can control the stage sync period. They're two different features, right?
blxdyx
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support step-by-step stage sync, like step is 1, stage sync will sync block one by one