Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker cursor does not display in the correct position #502

Closed
6 tasks done
wongnam opened this issue May 22, 2019 · 4 comments
Closed
6 tasks done

Color picker cursor does not display in the correct position #502

wongnam opened this issue May 22, 2019 · 4 comments

Comments

@wongnam
Copy link

wongnam commented May 22, 2019

What are the steps to reproduce?

Sorry, I update again. Color picker cursor does not display in the correct position where i pointed to.

ignore this -> Color picker cannot chose the color in inner of color circle.

What do you expect to happen?

It display in the correct position where i pointed to.

Please tell us about your environment:

  • Node-RED-Dashboard version: 2.15.2
  • Node-RED version: 0.20.4
  • node.js version: v8.12.0
  • npm version: 6.9.0
  • Platform/OS: Raspberry Pi 3B+ / Raspbian Stretch
  • Browser: MS Edge, Google Chrome

Screen shot:

image

@wongnam wongnam changed the title Color picker cannot chose the color in inner of color circle. Color picker cursor does not display in the correct position May 22, 2019
@dceejay dceejay added this to Work in Progress in Dashboard - Things to do May 22, 2019
@dceejay
Copy link
Member

dceejay commented May 22, 2019

the value you get is where you clicked - it's just the cursor shown position that is wrong. We did patch the picker for some reason I can no longer recall... (Indeed was something to do with LED lights but.... I think it was so that you could change from a colour to white (or black) within the single dial - without it the colour wheel just set the saturation andyou then had to set the brightness separately.

Basically it's a 3d problem - and which 2 dimensions you represent on the 2d wheel.

In meantime I have also added an option for the square version of the widget which makes things like greyscale easier to create.

@dceejay
Copy link
Member

dceejay commented May 22, 2019

My current thinking is to try to replace the rgb wheel with a version that is white in centre and dark at the edges - so full colour would be 50% in from edge - that way we can get from white to black and full colours...

@wongnam
Copy link
Author

wongnam commented May 23, 2019

Yes, when it is selected, it will still be valid. It's just a pointer that isn't in the right place.
The way the current color picker works is fine, but it is nice to have a square version. The best is to have 2 types of pickers, to have an option for the user.

@wongnam
Copy link
Author

wongnam commented May 23, 2019

when moved the lightness slider to different level that the cursor does not move to the corresponding position on the color wheel.

@dceejay dceejay moved this from Work in Progress to Released to npm - 2.15.0, 1, 2, 3 in Dashboard - Things to do May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants