Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending authenticated emails with v0.1.18 is broken #279

Closed
timolehto opened this issue Feb 21, 2017 · 3 comments
Closed

Sending authenticated emails with v0.1.18 is broken #279

timolehto opened this issue Feb 21, 2017 · 3 comments

Comments

@timolehto
Copy link
Contributor

Broken by this pr: #277

What is broken is that the auth options are not passed as options to the createTransport method anymore, but instead are set on the NodeMailer instance returned by that method and NodeMailer couldn't care any less about such things. It is the SMTPTransport that checks the auth options here:
https://github.com/nodemailer/nodemailer-smtp-transport/blob/v1.1.0/src/smtp-transport.js#L145

So, this pr should probably be reversed and a new release be made asap as it likely breaks every auth using email sending node-red out there.

timolehto added a commit to timolehto/node-red-nodes that referenced this issue Feb 21, 2017
@timolehto
Copy link
Contributor Author

Or accept my hotfix ^

@dceejay
Copy link
Member

dceejay commented Feb 21, 2017

apologies - I'm on a slow 2g link and didn't see this - must have crossed in the ether.. yes will probably accept yours later when back on a decent link as it's a better fix

dceejay pushed a commit that referenced this issue Feb 21, 2017
@timolehto
Copy link
Contributor Author

Seems to be working now, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants