Pushover TTL #1013
Merged
Pushover TTL #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pick up msg.ttl and pass it to REST API, checking it is a positive integer first.
Reference ttl parameter in api docs
|
Thanks for taking the time to contribute. It looks good to me @wooferguy & I see you have been testing this in various scenarios / feeding back to the community to (https://discourse.nodered.org/t/feature-request-pushover-ttl/78401) @dceejay is currently away so may not pick this up immediately. Thanks |
|
Looks good - will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Utilizes updated API to add TTL to Pushover notifications
Checklist
gruntto verify the unit tests pass