New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sqlite Node - docs update #869
Conversation
1. Updated node readme to match node's html help. 2. Added Example clarifying the use of parameters in a msg.topic query.
Hi @unborn-andy - Any chance you can click/sign the CLA so we can accept and merge this PR ? Thanks |
Hi - yes look fine to me... - did you want to update it before I merge it in light of the other PR ? |
what do you mean ? |
Hi - yes I will have to bump the version but that is OK... it's better that you don't bump the version and leave that for me - for exactly the reason you spotted - ie if I wanted to add multiple changes into the one release... I was just wondering if you wanted to add to the info. |
yes .. i asked in the Forum thread about this ..
So based on the above examples .. we can pass params as named params with the $ syntax but ? is also valid. Maybe we can accept both ways of passing parms. If its worth it ;)
|
Ah no they are different - first passes an array of values the second passes and object with named properties. |
Types of changes
Updated sqlite node README.md to match the more detailed node html file (the usage info was already there)
This can give better information to users that dont have the node installed but want to see how it works from the readme.md file.
Also added an example of how to use parameters Via msg.topic for both node html and README.md