Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Calendar #18

Merged
merged 2 commits into from
Oct 21, 2014
Merged

Google Calendar #18

merged 2 commits into from
Oct 21, 2014

Conversation

hindessm
Copy link
Contributor

Work in progress for a google calendar node. Several starting points for discussion:

  • I've missed something in search/replacing the flickr code so the 'displayName` doesn't seem to be used correctly. I can't see why. Fixed. Thanks to @hbeeken for spotting my mistake.
  • At the moment, the google config node requests profile and calendar scope. This is fine for now. In future, I think the GoogleNode should request profile scope and the calendar node should request the calendar scope. And later other nodes can incrementally increase the scope. Google supports this kind of incremental approach. Or maybe the google node just requests the scopes from the nodes that use it - is there a way to find this out from the config node? - and re-authorizes with the complete new set.
  • The refresh process - it is not trivial but I think I've got it working reliably.
  • There should be a way to re-authenticate - in case of errors with the refresh process.

Comments/thoughts welcome.

@knolleary knolleary changed the title Google Calendar [DO NOT MERGE] [wip] Google Calendar Sep 18, 2014
@hindessm
Copy link
Contributor Author

I think this is sufficient for an initial, useful implementation. (I'll add some notes regarding further work to issue #16.)

@hindessm hindessm changed the title [wip] Google Calendar Google Calendar Sep 25, 2014
@hindessm hindessm mentioned this pull request Sep 25, 2014
Open
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 95aed09 on hindessm:google-calendar into 16a52f4 on node-red:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0e4f459 on hindessm:google-calendar into 2d18c37 on node-red:master.

zobalogh
zobalogh reviewed Oct 17, 2014
View reviewed changes
google/google.html
<script type="text/x-red" data-template-name="google-credentials">
<div id="node-config-google-client-keys">
<div class="form-row">
<p style="margin-top: 10px;"><b>1.</b> Create your own project by following these <a href="https://developers.google.com/api-client-library/javascript/start/start-js#Getaccesskeysforyourapplication" target="_blank" style="text-decoration:underline;">instructions</a></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably add more information into the tooltip here to be honest. This is because there are several options available on the Google pages and therefore the user might need more guidance. I personally got confused. Just finding out as I write this why I got 401, invalid_client from Google!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like either the anchor is wrong or it has changed. It should be #Getkeysforyourapplication then I think the instructions are pretty clear?

I've now fixed the anchor. Thanks Zoltan. I'm curious to know if you still think the instructions are not clear.

@hindessm hindessm force-pushed the google-calendar branch 2 times, most recently from 261a4aa to f4b903c Compare October 21, 2014 07:39
knolleary added a commit that referenced this pull request Oct 21, 2014
@knolleary
Merge pull request #18 from hindessm/google-calendar
490d780 
Google Calendar
@knolleary knolleary merged commit 490d780 into node-red:master Oct 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hindessm @coveralls @zobalogh @knolleary