Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added i18n help files #271

Merged
merged 1 commit into from
Mar 12, 2021
Merged

added i18n help files #271

merged 1 commit into from
Mar 12, 2021

Conversation

heikokue
Copy link
Contributor

@heikokue heikokue commented Mar 8, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

separation of help-parts to separate en-US locales html files.
no content changes.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 71.056% when pulling a3b70d9 on heikokue:i18n-de/help into 5ab566d on node-red:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 71.056% when pulling a3b70d9 on heikokue:i18n-de/help into 5ab566d on node-red:master.

@dceejay
Copy link
Member

dceejay commented Mar 11, 2021

Hi thanks for all these - please note that we rarely update/maintain some of these nodes as they were "gifted" to us by another group - so while I'm happy for any contributions please don't bust a gut translating any you don't actually need to.

It's gong to take a while to go through them all before we can merge/republish them all - it would have been easier if a) they had been discussed on the forum first and b) were in smaller chunks of a few nodes at a time.

@heikokue
Copy link
Contributor Author

Hello! Oh, sorry for my endeavor to improve Node-RED. We have current Corona lockdown in Germany and I tried to spent my time for are meaningful job. Up to now I spent over 50 hours to improve the german UI.

Regarding a) The plan to improve the DE translation is already discussed in Slack channel #18n-de and in the Forum https://discourse.nodered.org/t/german-translation-anyone-interested/38209/4. The feedback is quite small...

Regarding b) This PR has no content change. Only the help text parts in the of the node's main html files are moved into separated html files in locales/en-US folder.
This shall be the 1st step, before as 2nd step the DE translations shall be added in locales/de folder in separate PRs.

How to continue?
Shall I split this PR node for node?

@dceejay
Copy link
Member

dceejay commented Mar 12, 2021

Hi
no problem - I will accept this PR as is - it will just take some time to check through it all. When it comes to actual translations - please only do the ones you need to start with - as I said many of the others are somewhat "legacy" so may not be needed at all (eg the tfl API has long since stopped working and do foursquare still exist ? so check before actually translating.

@heikokue
Copy link
Contributor Author

yes, I agree, I want only translate nodes, which are popular here in Germany and which has high download rates, checked on https://flows.nodered.org.
Escpecially in social nodes of providers, which are obselete or unknown in Germany, I will invest no efforts.

@dceejay dceejay merged commit 36bcdb1 into node-red:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants