Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed google calendar i18n support #273

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

heikokue
Copy link
Contributor

@heikokue heikokue commented Mar 13, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

this two dynamic words are forgotten to support i18n (see picture)
and calendar.label.before and calendar.label.start are double/obsolete

grafik

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.026% when pulling 1245b4c on heikokue:fix_google_calender_i18n into a8a3bd8 on node-red:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.026% when pulling 1245b4c on heikokue:fix_google_calender_i18n into a8a3bd8 on node-red:master.

@dceejay dceejay merged commit 7a47b1e into node-red:master Mar 13, 2021
@dceejay
Copy link
Member

dceejay commented Mar 13, 2021

Good spot - thanks - I won't republish until translation in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants