Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added category translation to google directions/geocoding & openweathermap #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heikokue
Copy link
Contributor

@heikokue heikokue commented Mar 29, 2021

  • [?] Bugfix (non-breaking change which fixes an issue)
  • [?] New feature (non-breaking change which adds functionality)

Proposed changes

  • added category translation to google directions/geocoding & openweathermap

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

coveralls commented Mar 29, 2021

Coverage Status

Coverage remained the same at 71.026% when pulling 779a4fb on heikokue:category_translation into e0c0dd3 on node-red:master.

@dceejay
Copy link
Member

dceejay commented Mar 29, 2021

I know the fitbit api has been broken/changed for ages - not sure about the strava one.

We inherited the node-red-web-nodes from another group - and they are rarely maintained and not often used by ourselves. - So really not much point in updating them unless you have tested them.

@thebaldgeek
Copy link

thebaldgeek commented Mar 29, 2021 via email

@heikokue heikokue changed the title added category translation to fitbit, google directions/geocoding, op… added category translation to google directions/geocoding & openweathermap Mar 30, 2021
@heikokue
Copy link
Contributor Author

OK, I changed to only google directions/geocoding & openweathermap

@heikokue
Copy link
Contributor Author

heikokue commented Mar 30, 2021

please wait with bump!
the DE helps of google and openweathermap are still outstanding.
both nodes have quite high download rates...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants