AWS - bucket not required in form for s3query and s3out #303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Amazon S3" and "Amazon S3 Out" nodes support providing the
bucket
property through the incoming message.However the HTML form specify the property as required which creates a warning on deploy.
PR provided as discussed on the forum : https://discourse.nodered.org/t/node-red-node-aws-html-form-state-bucket-is-required-which-prevent-providing-from-msg/71165
Types of changes
Proposed changes
By changing the descriptor of the bucket property in the form, the warning disapear.
Checklist
grunt
to verify the unit tests passTest has been performed on a local node-red instance. No unit tests were applied as I don't know how to run them.