Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS - bucket not required in form for s3query and s3out #303

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

jeanmichel-nwsb
Copy link
Contributor

"Amazon S3" and "Amazon S3 Out" nodes support providing the bucket property through the incoming message.
However the HTML form specify the property as required which creates a warning on deploy.

PR provided as discussed on the forum : https://discourse.nodered.org/t/node-red-node-aws-html-form-state-bucket-is-required-which-prevent-providing-from-msg/71165

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

By changing the descriptor of the bucket property in the form, the warning disapear.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Test has been performed on a local node-red instance. No unit tests were applied as I don't know how to run them.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 24, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jeanmichel-nwsb / name: Jean-Michel Mercier (fc27437)

@dceejay dceejay merged commit 9389ef0 into node-red:master Nov 24, 2022
dceejay pushed a commit that referenced this pull request Nov 24, 2022
@dceejay
Copy link
Member

dceejay commented Nov 24, 2022

Thanks - published as v0.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants