Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropbox local resources url #306

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

bartbutenaers
Copy link
Contributor

  • [ X ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

@dceejay,
I my previous pull request for the dropbox node, I had already added a sha256.js file to the local 'resources' folder:

image

That file contains a custom sha256 hash calculation function, for users that access their flow editor via a plain http connection. Because when not using SSL, the sha256 digest function of the Web Crypto API is not accessible in e.g. Chrome.

However @twocolors mentioned that I was not using this file, but instead I was using the same file from a public web server. I had already tested that last week, but somehow the local link got lost somewhere in my developments...

It is now fixed to get the local file (as described in the Node-RED documentation):

image

I have tested this, by requesting a new refresh token via a plain http connection for my flow editor.

Thanks for reviewing!!
Bart

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@dceejay dceejay merged commit 11a8819 into node-red:master Jan 10, 2023
@dceejay
Copy link
Member

dceejay commented Jan 10, 2023

Thanks again for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants