Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
@dceejay,
I my previous pull request for the dropbox node, I had already added a sha256.js file to the local 'resources' folder:
That file contains a custom sha256 hash calculation function, for users that access their flow editor via a plain http connection. Because when not using SSL, the sha256 digest function of the Web Crypto API is not accessible in e.g. Chrome.
However @twocolors mentioned that I was not using this file, but instead I was using the same file from a public web server. I had already tested that last week, but somehow the local link got lost somewhere in my developments...
It is now fixed to get the local file (as described in the Node-RED documentation):
I have tested this, by requesting a new refresh token via a plain http connection for my flow editor.
Thanks for reviewing!!
Bart
Checklist
grunt
to verify the unit tests pass