Skip to content

Commit

Permalink
Remove websocket listeners on close
Browse files Browse the repository at this point in the history
Fixes #285
  • Loading branch information
knolleary committed Jul 23, 2014
1 parent 5179cc7 commit c079576
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions nodes/core/io/22-websocket.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,12 @@ module.exports = function(RED) {
// Workaround https://github.com/einaros/ws/pull/253
// Remove listeners from RED.server
var listener = null;
for (var event = 0; event < node._serverListeners.length; event++) {
listener = node._serverListeners[event];
if(typeof listener === "function"){
RED.server.removeListener(event,listener);
for(var event in node._serverListeners) {
if (node._serverListeners.hasOwnProperty(event)) {
listener = node._serverListeners[event];
if(typeof listener === "function"){
RED.server.removeListener(event,listener);
}
}
}
node._serverListeners = {};
Expand Down

1 comment on commit c079576

@dceejay
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted Lawrence !
Apologies to all for introducing this bug ! mea cupla.

Please sign in to comment.