Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit button not visible in German #2338

Closed
5 tasks
unixweb opened this issue Oct 18, 2019 · 5 comments
Closed
5 tasks

commit button not visible in German #2338

unixweb opened this issue Oct 18, 2019 · 5 comments
Labels

Comments

@unixweb
Copy link

unixweb commented Oct 18, 2019

That way the whole Node-RED user community can help, rather than rely on the core development team.

To help us understand the issue, please fill-in as much of the following information as you can:
-->

What are the steps to reproduce?

If you switch in Settings language in German

What happens?

Commit Button for "Local Changes" not visible if you change in Settings to German

What do you expect to happen?

Commit for Local Changes not available
Bildschirmfoto 2019-10-18 um 19 07 31
Bildschirmfoto 2019-10-18 um 19 07 59

Please tell us about your environment:

  • Node-RED version: 1.0.1
  • Node.js version: 10.15.2
  • npm version: 5.8
  • Platform/OS: GNU Linux Buster
  • Browser: Firefox
@knolleary
Copy link
Member

If you make the sidebar a bit wider does the button appear?

Suspect the length of the German text is pushing the button offscreen.

@unixweb
Copy link
Author

unixweb commented Oct 18, 2019

Correct Nick if i push the sidebar wider i can see it ...
The German translated text is very long and covers the menu
Bildschirmfoto 2019-10-18 um 19 17 26

@jwende
Copy link
Contributor

jwende commented Oct 18, 2019

Ok ... i see the problem. Any recommendation for a better translation is welcome.
Cheers
Joerg

@pdong
Copy link
Contributor

pdong commented Oct 19, 2019

Thoughts on something like this?

ellipsis

We could position the buttons absolutely and then set padding on the red-ui-sidebar-vc-change-header headers then have the text overflow with ellipsis.

The tricky part is that since the buttons have translation strings they can be different widths as well.

@kuema
Copy link

kuema commented Oct 21, 2019

Ok ... i see the problem. Any recommendation for a better translation is welcome.

Besides the display issue, I would leave "commit" as-is in the translation. "Festschreiben" does not even make sense to me.
The same goes for other technical translations as well (e.g. "Deploy").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants