Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPIn converts content-type: "application/x-protobuf" to string #2935

Closed
mweissdigchg opened this issue Apr 15, 2021 · 1 comment
Closed

HTTPIn converts content-type: "application/x-protobuf" to string #2935

mweissdigchg opened this issue Apr 15, 2021 · 1 comment

Comments

@mweissdigchg
Copy link

"application/x-protobuf" refers to binary Protocol Buffers so output should be a Buffer

#1023 was a similar issue

Tested on Docker Image nodered/node-red:latest (created 2021-04-08)
NODE_VERSION | 10.24.1
YARN_VERSION | 1.22.5
NODE_RED_VERSION | v1.3.1
hardillb added a commit to hardillb/node-red that referenced this issue Apr 15, 2021
@hardillb
Possible fix for node-red#2935
9f418c6 
This is a quick fix, but it feels wrong to just start to build a
list of `application/*` that should be binary.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types#types

This sort of implies that `application/*` should be considered binary
unless otherwise known
@hardillb hardillb mentioned this issue Apr 15, 2021
Merged
6 tasks
hardillb added a commit to hardillb/node-red that referenced this issue Apr 16, 2021
@hardillb
Fix for node-red#2935
2356900
knolleary added a commit that referenced this issue Apr 16, 2021
@knolleary
Merge pull request #2938 from hardillb/dev
374ef39 
Fix for #2935
@knolleary
Copy link
Member

Fixed in 1.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knolleary @mweissdigchg