Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typed Input with no value is not removing focus class when unfocus + selected item of the list is not focused in the list #2945

Closed
5 tasks
Zehir opened this issue Apr 20, 2021 · 4 comments

Comments

@Zehir
Copy link

Zehir commented Apr 20, 2021

Edit : There is an other similar issue in the first comment If you want me to open a new issue tell me ;)

What are the steps to reproduce?

Open a new change node,
Add some timestamp value
Focus the timestamp value and select something else.

What happens?

The blue border is not removed when unfocus like the other inputs

What do you expect to happen?

Don't have the blue border when unfocus.
This hapen every time the selected type has no value

I made a gif to make this more easier to understand.
Qzi7xYUQFU

Please tell us about your environment:

  • Node-RED version: 1.3.2
  • Node.js version: v15.14.0
  • npm version: 7.10.0
  • Platform/OS: Windows 10
  • Browser: Chrome 90 in private mode
@Zehir
Copy link
Author

Zehir commented Apr 20, 2021

I found a similar case with the selected option of the list. It's still the first item that is displayed as selected.
In the gif we can see that when the false is selected it's still true that is darker.
HzGOSpXwqy

@Zehir Zehir changed the title typed Input with no value is not removing focus class when unfocus typed Input with no value is not removing focus class when unfocus + selected item of the list is not focused in the list Apr 20, 2021
@Zehir
Copy link
Author

Zehir commented Apr 20, 2021

Thanks @knolleary , did that fix the second issue too ?

@knolleary
Copy link
Member

Yes, there are two separate commits, one for each issue.

@Zehir
Copy link
Author

Zehir commented Apr 20, 2021

Perfect thanks à lot, you did a really good job with typedInput. It's verry easy to create new nodez with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants