Function Node Editor Bg gone to White (again) #3779

3ative · 2022-07-17T17:21:43Z

Current Behavior

After update 3.0 the Function Node Editor background is White (not dark)

Expected Behavior

No response

Steps To Reproduce

No response

Example flow

paste your flow here

Environment

Node-RED version: 3.0
Node.js version: v16.15.0
npm version:
Platform/OS: Home Assistant OS 8.2
Browser: Chrome 103.0.5060.114

The text was updated successfully, but these errors were encountered:

hardillb · 2022-07-17T17:23:28Z

Please fill our the whole template and include details of which theme you are using.

Steve-Mcl · 2022-07-17T17:24:44Z

I'm pretty sure this is due to the theme you are using not been updated to set the Monaco theme.

Have you checked to see if there is an update to your current theme?

You can also manually set the Monaco theme in the settings.js file of you wish.

3ative · 2022-07-18T01:01:22Z

Please fill our the whole template and include details of which theme you are using.

I've tried to add all the info I could find. My NR is an add-on in Home Assistant. It's using the "midnight-Red" theme... or most of at least LOL

If you need anything else, please let me know what and where/how to find it. :)

3ative · 2022-07-18T01:06:29Z

@Steve-Mcl
Thanks for the reply... I've looked around and did notice that info too - Something about themes being managed by another rep.
Sadly, the instructions for updating didn't point me to anything I could use/understand - I'm not a Unix guy and my NR is an add-on in Home Assistant.
I tried some of the commands I found, in what I think was Terminal, but got some errors about destination paths, etc.

Steve-Mcl · 2022-07-18T07:31:04Z

Hi, we don't use HA so not certain we can help other than offer some pointers. You may need to ask for help on the HA forum.

I know that the excellent theme pack by @bonanitech has been updated for v3 & pretty sure the themes set an appropriate code editor theme
If you know how to (or can find out how to) edit your settings.js file , you can choose from any of the built in Monaco themes - take a look at this post on the forum: https://discourse.nodered.org/t/editor-text-size/53944/4

Steve-Mcl · 2022-07-18T07:33:32Z

Also, I forgot to add, if this theme is provided/created by the HA team, It would probably be a good thing to let them know (via an issue on their repository) that the theme in question does not set an appropriate Monaco theme.

bonanitech · 2022-07-18T09:56:33Z

@3ative, it looks like you have theme: "vs" enabled in your settings.js.
Just comment out that line and then restart Node-RED.

EDIT: The settings file is in the /config/node-red directory in the add-on for Home Assistant.

3ative · 2022-07-18T11:58:54Z

Thanks for all the replies ppl.

Like I said I'm in no way a linux guy 😁 but here's what I could find:
In the config tab of Node-Red (HA Add-on Page) I have set the theme;

And everything in the NR interface is the same colours as before, etc apart from the BG of the Function Node Editor- as seen in the OP.

So [most] of the theme is being used.

As for the settings.js, there is no [theme:] so, I'm guessing the above setting is covering that bit. :)

    // The following property can be used to order the categories in the editor
    // palette. If a node's category is not in the list, the category will get
    // added to the end of the palette.
    // If not set, the following default order is used:
    paletteCategories: [
        'home_assistant',
        'subflows',
        'input',
        'output',
        'function',
        'social',
        'mobile',
        'storage',
        'analysis',
        'advanced'
    ],

    // Configure the logging output
    logging: {
        // Only console logging is currently supported
        console: {
            // Whether or not to include metric events in the log output
            metrics: false,
            // Whether or not to include audit events in the log output
            audit: false
        }
    },

    // Customising the editor
    editorTheme: {
        projects: {
            // To enable the Projects feature, set this value to true
            enabled: false
        }
    }
}

From what I can gather, this "midnight-red" theme IS still being used, it's just the Function Node Editor BG part of the theme itself that hasn't been updated.

Also, while looking at the docs and other web page about updating themes... it talks about npm install to place a theme in a "theme" folder... which there isn't one in /config/node-red.

bonanitech · 2022-07-18T17:21:58Z

I'll work with the add-on developer to find a fix for this.

3ative · 2022-07-18T20:33:52Z

@bonanitech Thank you, it's very much appreciated.
The "midnight-red" is the only one I use and it looks so good in my tutorial videos... can't wait to get back to it and show off the new features in V3

I've downgraded to NR 2.2.2, for the moment.

knolleary · 2022-07-20T09:43:07Z

Closing this issue as it is an upstream theme issue.

3ative · 2022-07-20T12:32:07Z

@knolleary Please explain "upstream theme issue" and let me know who I need to ask about getting it fixed.
Thanks.

3ative · 2022-07-20T12:33:53Z

@knolleary Sorry, belay my last... I believe @bonanitech is looking into it.

knolleary · 2022-07-20T12:52:08Z

@3ative the core node-red project doesn't maintain any custom themes for the editor. They are mostly all provided by the excellent work done by @bonanitech.

The problem you are having will not lead to any code changes or fixes in Node-RED itself (which is what this issue list is for tracking) - this is what 'upstream' means in this context.

3ative · 2022-07-20T20:45:06Z

@3ative the core node-red project doesn't maintain any custom themes for the editor. They are mostly all provided by the excellent work done by @bonanitech.

The problem you are having will not lead to any code changes or fixes in Node-RED itself (which is what this issue list is for tracking) - this is what 'upstream' means in this context.

I understand now it's not a NR issue and is something in addition to... Thanks for the clarification too. 👍

bonanitech · 2022-07-21T11:53:08Z

It looks like the problem is that they don't have codeEditor in their settings.

bonanitech · 2022-07-21T12:15:46Z

@knolleary, shouldn't it work anyway?

EDIT: Maybe something related to #3732?

knolleary · 2022-07-21T12:54:55Z

@bonanitech can you explain a bit more? Is this not related to the theme then? Do you have a way to recreate this?

bonanitech · 2022-07-21T13:07:00Z

If there is no codeEditor object in settings.js, it will not load the customizations made in the theme.

Steve-Mcl · 2022-07-21T13:11:00Z

I'll take a look

@knolleary is there time before 3.0.1 for me to see if I can resolve this?

knolleary · 2022-07-21T13:23:56Z

@Steve-Mcl we need to get 3.0.1 released today. I would rather not being doing that late in the evening. If there's a fix that is forthcoming, then yes. Otherwise it'll have to wait until 3.0.2.

Steve-Mcl · 2022-07-21T13:32:39Z

5 mins I will push modification - i believe is straight forward and non invasive.

If it makes the cut, great. If not, then 3.0.2

Steve-Mcl · 2022-07-21T13:47:38Z

@knolleary PR done (tests running)

bonanitech · 2022-07-21T14:43:14Z

Thanks, guys!

3ative · 2022-07-21T20:28:37Z

🥰 Great work guys... but,Alas it didn't make 3.0.1

Looking forward to 3.0.2 😀

knolleary · 2022-07-21T20:29:18Z

@3ative 3.0.1 has not been published yet. Other things got in the way. We'll get it released tomorrow.

3ative · 2022-07-21T20:41:11Z

@3ative 3.0.1 has not been published yet. Other things got in the way. We'll get it released tomorrow.

LOL Yeah, I saw this in my Home Assistant and got excited. 🤣

3ative · 2022-07-27T06:22:53Z

I can confirm that with the latest Home Assistant Add-on update for NR... Now is all good.

Thanks go to everyone involved. 💖

3ative added the needs-triage label Jul 17, 2022

Steve-Mcl added upstream and removed needs-triage labels Jul 17, 2022

knolleary closed this as completed Jul 20, 2022

Steve-Mcl mentioned this issue Jul 21, 2022

Allow codeEditor theme to be set even if codeEditor is not set in settings.js #3794

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Function Node Editor Bg gone to White (again) #3779

Function Node Editor Bg gone to White (again) #3779

3ative commented Jul 17, 2022 •

edited

hardillb commented Jul 17, 2022

Steve-Mcl commented Jul 17, 2022

3ative commented Jul 18, 2022 •

edited

3ative commented Jul 18, 2022

Steve-Mcl commented Jul 18, 2022

Steve-Mcl commented Jul 18, 2022 •

edited

bonanitech commented Jul 18, 2022 •

edited

3ative commented Jul 18, 2022

bonanitech commented Jul 18, 2022

3ative commented Jul 18, 2022 •

edited

knolleary commented Jul 20, 2022

3ative commented Jul 20, 2022

3ative commented Jul 20, 2022

knolleary commented Jul 20, 2022

3ative commented Jul 20, 2022

bonanitech commented Jul 21, 2022

bonanitech commented Jul 21, 2022 •

edited

knolleary commented Jul 21, 2022

bonanitech commented Jul 21, 2022

Steve-Mcl commented Jul 21, 2022

knolleary commented Jul 21, 2022

Steve-Mcl commented Jul 21, 2022

Steve-Mcl commented Jul 21, 2022

bonanitech commented Jul 21, 2022

3ative commented Jul 21, 2022

knolleary commented Jul 21, 2022

3ative commented Jul 21, 2022

3ative commented Jul 27, 2022

Function Node Editor Bg gone to White (again) #3779

Function Node Editor Bg gone to White (again) #3779

Comments

3ative commented Jul 17, 2022 • edited

Current Behavior

Expected Behavior

Steps To Reproduce

Example flow

Environment

hardillb commented Jul 17, 2022

Steve-Mcl commented Jul 17, 2022

3ative commented Jul 18, 2022 • edited

3ative commented Jul 18, 2022

Steve-Mcl commented Jul 18, 2022

Steve-Mcl commented Jul 18, 2022 • edited

bonanitech commented Jul 18, 2022 • edited

3ative commented Jul 18, 2022

bonanitech commented Jul 18, 2022

3ative commented Jul 18, 2022 • edited

knolleary commented Jul 20, 2022

3ative commented Jul 20, 2022

3ative commented Jul 20, 2022

knolleary commented Jul 20, 2022

3ative commented Jul 20, 2022

bonanitech commented Jul 21, 2022

bonanitech commented Jul 21, 2022 • edited

knolleary commented Jul 21, 2022

bonanitech commented Jul 21, 2022

Steve-Mcl commented Jul 21, 2022

knolleary commented Jul 21, 2022

Steve-Mcl commented Jul 21, 2022

Steve-Mcl commented Jul 21, 2022

bonanitech commented Jul 21, 2022

3ative commented Jul 21, 2022

knolleary commented Jul 21, 2022

3ative commented Jul 21, 2022

3ative commented Jul 27, 2022

3ative commented Jul 17, 2022 •

edited

3ative commented Jul 18, 2022 •

edited

Steve-Mcl commented Jul 18, 2022 •

edited

bonanitech commented Jul 18, 2022 •

edited

3ative commented Jul 18, 2022 •

edited

bonanitech commented Jul 21, 2022 •

edited