Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaulting to monaco if settings does not contain codeEditor #3732

Merged
merged 2 commits into from Jul 3, 2022

Conversation

knolleary
Copy link
Member

We didn't do a complete enough job of defaulting to monaco. If the settings.js file doesn't contain a codeEditor entry, the editor will default to monaco, but the runtime will not have ensured the monaco library was loaded by the editor.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 68.33% when pulling ca20f41 on fix-monaco-default into f760354 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants