Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For long running node installs show a message #4622

Open
hardillb opened this issue Mar 26, 2024 · 2 comments · Fixed by #4662
Open

For long running node installs show a message #4622

hardillb opened this issue Mar 26, 2024 · 2 comments · Fixed by #4662

Comments

@hardillb
Copy link
Member

Current Behavior

If a node install takes a long time the UI just returns to the list of nodes in the catalogue and allows the currently installing node button to be pressed again.

Expected Behavior

The UI should show a message saying the install will continue in the background at the the node will be added to a palette once complete.

Installing other (or attempting to install the same node again) nodes should be blocked until the first completes

Steps To Reproduce

On a slow machine (limited memory and CPU resources) install a large node e.g openapi-red and wait

Example flow

NA

Environment

  • Node-RED version: 3.1.7
  • Node.js version: 18.x
  • npm version: 9.x
  • Platform/OS: All
  • Browser: NA
@hardillb
Copy link
Member Author

hardillb commented Apr 8, 2024

Should this move to using the editor messaging API rather than wait on a long HTTP request to return (or time out in this case?

It already updates the UI when/if the install completes cleanly, just not if it fails.

@hardillb
Copy link
Member Author

OK, so the timeout is actually coming from the reverse proxy, Standalone Node-RED doesn't timeout it waits forever.

Question now is do we extend the reverse proxy timeout or still try and handle this better in Node-RED?

hardillb added a commit to hardillb/node-red that referenced this issue Apr 18, 2024
@knolleary knolleary linked a pull request May 17, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants