add parts support for HTML node #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dceejay
reviewed
Nov 30, 2017
| @@ -41,6 +46,11 @@ module.exports = function(RED) { | |||
| /* istanbul ignore else */ | |||
| if (pay2) { | |||
| msg.payload = pay2; | |||
| msg.parts = { | |||
| id: msg._msgid, | |||
| index: index, | |||
There was a problem hiding this comment.
should we also add the msg.parts.type ? in case someone wants to rebuild an array automatically ?
There was a problem hiding this comment.
Thank you for reviewing.
It seems to be useful.
And msg.parts.ch is also needed for automatic join.
|
Many thanks Nishiyama-san ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you hit that Submit button....
Please read our contribution guidelines
before submitting a pull-request.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyIf you want to raise a pull-request with a new feature, or a refactoring
of existing code, it may well get rejected if it hasn't been discussed on
the mailing list or
slack team first.
Proposed changes
Make HTML node to produce parts property like split node.
This allows messages extracted by HTML node processed
as a group.
Checklist
Put an
xin the boxes that applygruntto verify the unit tests pass