Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Japanese info text of core nodes #1638

Merged
merged 12 commits into from Feb 23, 2018

Conversation

HiroyasuNishiyama
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

This PR adds Japanese info text of core nodes.
Requires fix PR#1616 for message lookup of core nodes.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.755% when pulling c3c5194 on node-red-hitachi:i18n-info-jp into 50ae815 on node-red:master.

1 similar comment
@coveralls
Copy link

coveralls commented Feb 15, 2018

Coverage Status

Coverage remained the same at 87.755% when pulling c3c5194 on node-red-hitachi:i18n-info-jp into 50ae815 on node-red:master.

@knolleary knolleary merged commit 2029f6e into node-red:master Feb 23, 2018
@HiroyasuNishiyama HiroyasuNishiyama deleted the i18n-info-jp branch February 24, 2018 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants