Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix & document template library folder and type #1702 #1704

Closed
wants to merge 1 commit into from

Conversation

mblackstock
Copy link
Contributor

@mblackstock mblackstock commented Apr 19, 2018

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Changed template node to use correct library name and type (templates/template) and documented instructions in the node documentation info.

While templates saved in the library will be orphaned, there is not an easy solution for allowing users to migrate their templates from the current functions directory to the templates directory for a number of reasons:

  • node runtime does not have access to the library
  • lazy migration using the front end (e.g. open both libraries, save only to templates) would not be worthwhile considering the changes involved, the number of users this may effect (few?)
  • could write a migration script, but would be difficult to get right since code would need to distinguish between templates and functions.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

coveralls commented Apr 19, 2018

Coverage Status

Coverage remained the same at 87.755% when pulling abfe88d on SenseTecnic:fix-1702 into 2534530 on node-red:master.

@knolleary knolleary added this to the 0.19 milestone May 30, 2018
@knolleary knolleary modified the milestone: 0.19 Jul 10, 2018
<p>Before Node-RED 0.18.4, library template files were saved in the <i>functions</i> library located in the
Node-RED user directory (typically <code>.node-red</code> in the user's home directory). To access these saved templates,
after upgrading, make a copy of the template files and directories in <code>.node-red/functions</code> to
<code>.node-red/templates</code>.</p>
</script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this text? My assumption is this will affect a pretty small set of users so would rather not tarnish the node info with this. We can make sure it is highlighted in the release blog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants