Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support i18n in websocket node #1785

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Support i18n in websocket node #1785

merged 1 commit into from
Jul 10, 2018

Conversation

kazuhitoyokoi
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

I found that the status messages in websocket nodes are English. I fixed 22-websocket.js to support i18n.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 75.631% when pulling 0615444 on kazuhitoyokoi:master-fixwebsocketnode into 9d219c1 on node-red:master.

@knolleary knolleary merged commit 8b38fe9 into node-red:master Jul 10, 2018
@kazuhitoyokoi
Copy link
Member Author

@knolleary Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants