Accept both name and username #2109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Login seems to generally expect username to be set (eg when using auth0's default passport module, its failure to set username meant login failed) but in this code NR only checks for name. See here for mention of username: https://nodered.org/docs/security I think it would be safe to fallback to also accepting username, given other parts of NR seem to expect that to be set anyway. It seems a bit buggy to have to define both to satisfy different bits of code, but perhaps there are reasons for that I don't understand...
|
Thanks for this. I have investigated further and realised the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login seems to generally expect username to be set (eg when using auth0's default passport module, its failure to set username meant login failed) but in this code NR only checks for name.
See here for mention of username:
https://nodered.org/docs/security
I think it would be safe to fallback to also accepting username, given other parts of NR seem to expect that to be set anyway. It seems a bit buggy to have to define both to satisfy different bits of code, but perhaps there are reasons for that I don't understand...
Proposed changes
Checklist
gruntto verify the unit tests pass