Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding menu in file node #2125

Merged
merged 1 commit into from Apr 2, 2019
Merged

Fix encoding menu in file node #2125

merged 1 commit into from Apr 2, 2019

Conversation

kazuhitoyokoi
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Current encoding menu in file-in and file-out nodes doesn't have title, "Encoding" because message catalog doesn't contain the message. Therefore, I added the messages into the catalogs.
Simultaneously, I added visible/hidden handling in encoding menu when Node-RED user selects "delete file" in Action menu.

image

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 76.433% when pulling 0f57d1a on kazuhitoyokoi:master-fixfilenode into 63829b6 on node-red:master.

@knolleary knolleary merged commit 7b15ba3 into node-red:master Apr 2, 2019
@kazuhitoyokoi
Copy link
Member Author

@knolleary Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants