Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqtt enhancements - protocol version 5 support, mqtt node tests #2201

Closed
wants to merge 4 commits into from

Conversation

southbite
Copy link

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ knolleary
❌ Simon Bishop


Simon Bishop seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 76.25% when pulling fdc2f95 on southbite:dev into 8abc5b3 on node-red:dev.

@southbite southbite changed the title Dev mqtt enhancements - protocol version 5 support, mqtt node tests Jun 13, 2019
@southbite
Copy link
Author

closing rather - trying to figure out how package-lock found its way in, and how coverage could possibly have decreased - as I have added tests where there were none?

@southbite southbite closed this Jun 13, 2019
@knolleary
Copy link
Member

  1. rebase your branch on the latest code from dev so it doesn't drag in other changes as part of the merge
  2. don't worry about the exact coverage figures - if there's a genuine problem we'll discuss that when we review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants