Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message catalogue for SUBFLOW UI #2466

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

HiroyasuNishiyama
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Message catalogue entry for editor.types.cred is referenced but not defined.
This PR adds definition entries for en-US & ja locale.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.438% when pulling 2da1554 on node-red-hitachi:update-message-catalogue into 4f9395e on node-red:dev.

@knolleary
Copy link
Member

Ooops - missed that. Thanks!

@knolleary knolleary merged commit 54978e4 into node-red:dev Feb 24, 2020
@HiroyasuNishiyama HiroyasuNishiyama deleted the update-message-catalogue branch April 30, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants