Add reset feature to batch node #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knolleary
reviewed
May 5, 2020
| @@ -204,11 +209,19 @@ module.exports = function(RED) { | |||
| var interval = Number(n.interval || "0") *1000; | |||
There was a problem hiding this comment.
I realise this isn't related to the PR, but I noticed this line. If n.interval is set to 0 (or undefined) then this will setup an interval of 0ms - which sounds like a bad thing and unlikely to be something a user would actually want.
Should there be a safety check for a minimum interval value and default to a non-0 value to prevent accidentally performing a denial of service of the event loop?
There was a problem hiding this comment.
Added the check of the value of interval.
As additional information, current implementation limits the input value of the interval to be greater than 1, as shown below.
interval: {value:10,validate:function(v) { return RED.validators.number(v) && (v >= 1); }},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As discussed here, batch node has no way of resetting the internal state.
This PR realizes the means of resetting internal state by an input message.
Checklist
gruntto verify the unit tests pass