Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for settings.set subsequent updates #2584

Merged
merged 1 commit into from Jun 1, 2020
Merged

fix for settings.set subsequent updates #2584

merged 1 commit into from Jun 1, 2020

Conversation

sammachin
Copy link
Contributor

@sammachin sammachin commented May 31, 2020

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

By cloning the value the assert.deepEqual will now fail even for subsequent updates of the value without restarting Node-RED

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

By cloning the value the assert.deepEqual will now fail even for subsequent updates of the value without restarting Node-RED
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 77.51% when pulling a8d8540 on sammachin:sammachin-settings_set_fix into bcf1d98 on node-red:master.

@knolleary knolleary merged commit c6c4274 into node-red:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants