Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix char at error on undefined when opening websocket-listner #2610

Merged

Conversation

HiroyasuNishiyama
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Opening websocket-listner settings panel causes following editor error:

Definition error: websocket-listener.label TypeError: Cannot read property 'charAt' of undefined
    at Object.label (<anonymous>:113:27)
    at Object.getNodeLabel (red.min.js:16)
    at Object.p [as refresh] (red.min.js:16)
    at Object.show (red.min.js:16)
    at red.min.js:16

This PR tries to fix this problem.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 77.31% when pulling 7694349 on node-red-hitachi:fix-charAt-error-on-undefined into 81a4f42 on node-red:dev.

@knolleary knolleary merged commit b580020 into node-red:dev Jun 12, 2020
@HiroyasuNishiyama HiroyasuNishiyama deleted the fix-charAt-error-on-undefined branch December 2, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants