Update util.writeFile to write to tmp file before rename #2683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The Local Filesystem storage module has a utility function used to write files - this is used in a number of places such as the flow/credential files and the runtime settings (
.config.json
).The existing code does the follow:
This means there is a window of time where the original file has been renamed and the new content has not yet been written to the file.
I have seen a small number of times when using
grunt dev
(which will cause the node process to be killed whenever I modify a file) that the.config.json
file is corrupted and the runtime settings are lost.I cannot reliably reproduce it, but I'm pretty sure its related to killing Node-RED whilst its starting up.
This PR modifies the logic around the
writeFile
function. It now does:<file>.$$$
)That means the file has valid content through-out the process - as the final rename will be an atomic fs action.