Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid loading node html if disableEditor set #2684

Merged
merged 2 commits into from Sep 3, 2020
Merged

Avoid loading node html if disableEditor set #2684

merged 2 commits into from Sep 3, 2020

Conversation

knolleary
Copy link
Member

  • New feature (non-breaking change which adds functionality)

Proposed changes

This change modifies how nodes are loaded so that if disableEditor is set, we now skip loading the node html into memory.

This shaves a small amount off the startup time - not as much as I'd hoped. But it will save a bit of memory usage.

It still loads the locales files as a node may have runtime messages in its catalog.

Checklist

  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 77.072% when pulling 33855bc on skip-html into bcd85b1 on dev.

@knolleary knolleary added this to the 1.2 milestone Aug 28, 2020
@knolleary knolleary merged commit 2f2a636 into dev Sep 3, 2020
@knolleary knolleary deleted the skip-html branch January 11, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants