Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'done' metric log for message tracing #2685

Merged
merged 1 commit into from Sep 3, 2020

Conversation

k-toumura
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

To enable precise tracing of each message, we propose to make the runtime emit log message whenever the message processing is finished.
By this PR, nodes which use Messaging API (i.e., call done() at end of message processing) emit "done" event on metric log.

Example log output:

18 Aug 09:11:09 - [metric] {"level":99,"nodeid":"f748808a.a2b39","event":"node.http response.done","msgid":"59bf7151.69477","timestamp":1597709469150}

Further details are on the design note of Message Tracing by metric log.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 77.312% when pulling 0c5586d on node-red-hitachi:dev-tracemetric into bcd85b1 on node-red:dev.

@knolleary knolleary added this to the 1.2 milestone Aug 28, 2020
@knolleary knolleary merged commit b309161 into node-red:dev Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants