New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `this` context when calling multiple event listeners (fixes #2692). #2693

Merged

knolleary merged 1 commit into node-red:master from mgroenhoff:master

Sep 4, 2020

Contributor

mgroenhoff commented Sep 4, 2020

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Proposed changes

Fixes #2692

Checklist

I have read the contribution guidelines
For non-bugfix PRs, I have discussed this change on the forum/slack team.
I have run grunt to verify the unit tests pass
I have added suitable unit tests to cover the new/changed functionality


          Fix this context when calling multiple event listeners (fixes node-…

d84c2b7

…red#2692).

jsf-clabot commented Sep 4, 2020 •

edited

All committers have signed the CLA.

Member

knolleary commented Sep 4, 2020

Looks good - thanks for this.

knolleary merged commit 44b1819 into node-red:master

Contributor Author

mgroenhoff commented Sep 4, 2020 •

edited

Wow, that was quick! I noticed an error in the test which I pushed but it's closed already.

Member

knolleary commented Sep 4, 2020

Oops. I got a bit merge happy as it looked good. What's the fix on the test?

Contributor Author

mgroenhoff commented Sep 4, 2020 •

edited

It was a missing msg argument in the second event listener. I have corrected it in my fork. You can diff it to see the change.

Member

knolleary commented Sep 4, 2020

Got it - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment